fix: Unescape HTML entities in component index checkbox tree#948
Merged
fix: Unescape HTML entities in component index checkbox tree#948
Conversation
Collaborator
BarbaraOliveira13
left a comment
BarbaraOliveira13
left a comment
There was a problem hiding this comment.
I tested locally and It's seems not fix the bug.
@Stef-Rousset Can/Have you test locally ?
Contributor
|
hello @BarbaraOliveira13 , yes I tested it locally and it worked. As it is a deface override, may be you should compile deface and test again |
Collaborator
|
just for tracking: I can't reproduce but @Stef-Rousset can so we decided to bypass = |
moustachu
deleted the
fix/unescape-html-entities-filter-checkbox-tree
branch
moustachu
restored the
fix/unescape-html-entities-filter-checkbox-tree
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 Description
When creating a category name with special characters (like
"or'), the checkbox filter in the component index on the front end are labeled escape HTML entities (like").see example here (admin sign in needed)
This fix add a deface override on the checkbox tree shared template to unescape these entities.