fix: stop digest mail

[BarbaraOliveira13]

🎩 Description

Stop digest mail of decidim_ai if Decidim_ai is disabled

Testing

Follow the steps here with changing the activation of decidim_ai <-> true <-> false
in console with:
Rails.application.secrets[:decidim][:ai][:enabled] = false
Rails.application.secrets[:decidim][:ai][:enabled] = true
See that you receive or not, the email in letter_opener or in sidekiq tab log [✅ EMAIL SENT]

📌 Related Issues

https://github.com/orgs/OpenSourcePolitics/projects/26/views/1?filterQuery=decidim-ai&pane=issue&itemId=154971976&issue=OpenSourcePolitics%7Cintern-tasks%7C357
PR digest mail

Tasks

• Add specs
• In case of new dependencies or version bump, update related documentation

🛠️ If your PR introduces or updates an Override

• Add the label "override:pending" in your PR
• Add the corresponding label based on the review deadline category (when this override must be checked):
  • WHEN BACKPORT 0.29 ·
  • BEFORE MIGRATION 0.31 ·
  • WAITING FOR PR UPSTREAM ·
  • OTHER
• Add the link to the related Decidim issue or PR (if exist).

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Extra information

[moustachu]

Hello,

The DECIDIM_AI_ENABLED is set to true by default.
In our case, we want this flag to be false by default when the environment variable is missing (which will be the case on most of our platform when updating the v3.8+ version)

We should update the default value here :

• https://github.com/OpenSourcePolitics/decidim-app/blob/fix/stop_digest_mail/config/secrets.yml#L55
• https://github.com/OpenSourcePolitics/decidim-app/blob/fix/stop_digest_mail/.env-example#L53

[BarbaraOliveira13]

Hello,

The DECIDIM_AI_ENABLED is set to true by default. In our case, we want this flag to be false by default when the environment variable is missing (which will be the case on most of our platform when updating the v3.8+ version)

We should update the default value here :

• https://github.com/OpenSourcePolitics/decidim-app/blob/fix/stop_digest_mail/config/secrets.yml#L55
• https://github.com/OpenSourcePolitics/decidim-app/blob/fix/stop_digest_mail/.env-example#L53

Thanks! Indeed! I did the change request, but I'm not sure ... I update for ai:enabled, AND ALSO:

• ai:user_spam_analyzer_enabled, and
• ai:generic_spam_analyzer_enabled
  I'm not sure It was necessary for the last two ones ?

[moustachu]

I'm not sure for :

• ai:user_spam_analyzer_enabled, and
• ai:generic_spam_analyzer_enabled

I think we should leave them at true by default.

We only need ai:enabled because it's the one used on this PR.

[Stef-Rousset]

LGTM !