-
Notifications
You must be signed in to change notification settings - Fork 11
Add Cartopy background maps #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
overeem11
commented
Sep 23, 2025
- closes #xxxx (Replace xxxx with the GitHub issue number)
- Tests added and passed if fixing a bug or adding a new feature
- All code checks from pre-commit passed
- Added an entry in the CHANGELOG.md file
Add background map
…unctionality missing, though
|
@overeem11 I had a go at integrating some parts of what you have in the separate
Remaining TODOs:
@overeem11 What are crucial feature that are missing in you opinion? |
…ebook I did also refactor the exiting things a bit. This is not perfect yet, though. Maybe a better solution would be to completely remove the map background stuff from plot_lines and only have it in plot_plg because plot_lines could be a function that is not exposed to the user anyway since plot_plg has the same functionality plus the option to plot grid and points in addition...
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 98.75% 94.87% -3.89%
==========================================
Files 7 7
Lines 723 858 +135
==========================================
+ Hits 714 814 +100
- Misses 9 44 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Current status:
TODOs:
I will take a break with this PR and try to finish it next week. |
this is also the current state in upstream/main but I add it here manually

