Skip to content

feat(spp_change_request_v2): CR UX redesign with stage-based workflow #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emjay0921 wants to merge 2 commits into
base: 19.0
Choose a base branch
from

fix(cr): fix review log user clickable and batch wizard duplicate com…

90a3eec
Select commit
Loading
Failed to load commit list.
Open

feat(spp_change_request_v2): CR UX redesign with stage-based workflow #61

fix(cr): fix review log user clickable and batch wizard duplicate com…
90a3eec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 3, 2026 in 0s

64.66% (-6.70%) compared to a72ada0

View this Pull Request on Codecov

64.66% (-6.70%) compared to a72ada0

Details

Codecov Report

❌ Patch coverage is 53.21337% with 182 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.66%. Comparing base (a72ada0) to head (90a3eec).

Files with missing lines Patch % Lines
spp_change_request_v2/models/change_request.py 48.49% 120 Missing ⚠️
spp_change_request_v2/details/split_household.py 0.00% 11 Missing ⚠️
spp_change_request_v2/models/dms_file.py 42.10% 11 Missing ⚠️
spp_change_request_v2/wizards/create_wizard.py 62.96% 10 Missing ⚠️
...ge_request_v2/models/change_request_detail_base.py 38.46% 8 Missing ⚠️
spp_change_request_v2/tests/test_ux_wizards.py 45.45% 6 Missing ⚠️
spp_change_request_v2/wizards/revision_wizard.py 40.00% 6 Missing ⚠️
...change_request_v2/wizards/batch_approval_wizard.py 25.00% 3 Missing ⚠️
...e_request_v2/wizards/conflict_comparison_wizard.py 0.00% 3 Missing ⚠️
spp_change_request_v2/models/change_request_log.py 86.66% 2 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (a72ada0) and HEAD (90a3eec). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (a72ada0) HEAD (90a3eec)
spp_api_v2_cycles 1 0
spp_api_v2_products 1 0
spp_api_v2_service_points 1 0
spp_api_v2_data 1 0
spp_api_v2_entitlements 1 0
spp_aggregation 1 0
spp_api_v2 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             19.0      #61      +/-   ##
==========================================
- Coverage   71.36%   64.66%   -6.70%     
==========================================
  Files         319      274      -45     
  Lines       25878    21278    -4600     
==========================================
- Hits        18467    13760    -4707     
- Misses       7411     7518     +107

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov