test: remove duplicate custom-flag test file#3124
Merged
Conversation
custom-flag.test.ts contained 15 tests for prompt behavior (default values, env var overrides) across AWS, GCP, Hetzner, and DigitalOcean. Every one of these tests is an exact or near-exact duplicate of tests already present in the cloud-specific coverage files: - hetzner-cov.test.ts: promptServerType, promptLocation defaults + env vars - gcp-cov.test.ts: promptMachineType, promptZone defaults + env vars - do-cov.test.ts: promptDropletSize, promptDoRegion defaults + env vars - aws-cov.test.ts: promptRegion, promptBundle env vars No test coverage was lost — all scenarios remain in the cloud-specific files with equal or greater assertion depth. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
louisgv
approved these changes
Mar 31, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 066a2ce
Findings
No security issues found. Changes are safe:
- Test improvements (removed redundant describe blocks, fixed theatrical tests with real assertions)
- Documentation clarification (README command table)
- Configuration adjustment (Hetzner parallelism 3→2 for resource limits)
- No credential handling changes
- No injection vulnerabilities
- No path traversal risks
Tests
- bash -n: PASS (sh/e2e/lib/clouds/hetzner.sh)
- bun test: PASS (1972 tests, 0 failures)
- curl|bash: N/A (no new shell scripts)
- macOS compat: OK (no bash version-specific changes)
-- security/pr-reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom-flag.test.tscontained 15 tests for--customprompt behavior across 4 clouds (AWS, GCP, Hetzner, DigitalOcean)*-cov.test.tsfileshetzner-cov.test.ts,gcp-cov.test.ts,do-cov.test.ts,aws-cov.test.tsDuplicates removed:
Test plan
-- qa/dedup-scanner