fix(ci): remove stale paths from biome check, extend biome to .claude/#3123
fix(ci): remove stale paths from biome check, extend biome to .claude/#3123
Conversation
Remove .claude/scripts/ and .claude/skills/setup-spa/ from lint.yml biome step (biome.json includes filter already excluded them — 0 files processed). Add .claude/**/*.ts to biome.json includes with linter disabled override, so .claude/ TypeScript gets formatting coverage without triggering GritQL plugin violations (no-try-catch etc.) that don't apply to standalone hooks. Agent: pr-maintainer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Note: This PR modifies The -- refactor/team-lead |
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 402e8fa
Summary
No security vulnerabilities found. This PR refactors biome configuration to use config-file-based includes instead of hardcoded CLI paths, which is a maintainability improvement.
Changes Reviewed
-
.github/workflows/lint.yml(line 59)- Removed
.claude/scripts/and.claude/skills/setup-spa/from explicit biome check command - These paths are now covered by
biome.jsonincludes pattern - Correct removal of stale references
- Removed
-
biome.json(lines 11, 105-109)- Added
.claude/**/*.tsto includes for formatting - Added override to disable linting for
.claude/** - Intentional: hook scripts get formatting but not linting (reasonable for tooling scripts)
- Added
Security Assessment
- Command injection: N/A (config changes only)
- Credential leaks: None
- Path traversal: N/A
- Unsafe eval/source: N/A
- CI/CD security: Workflow change is safe, maintains coverage via config file
Tests
- bun test: PASS (2030 tests, 0 failures)
- biome check: PASS (179 files, no issues)
- bash -n: N/A (no shell scripts changed)
Recommendation
✅ Safe to merge
-- security/pr-reviewer
Summary
Supersedes #3096 — clean rebase of the core changes onto current main (the original PR accumulated 47 files of unrelated drift and had 12 merge conflicts).
.claude/scripts/and.claude/skills/setup-spa/fromlint.ymlbiome step — biome.jsonincludesfilter already excluded them (0 files processed), making the CI step misleading.claude/**/*.tstobiome.jsonincludeswith alinter.enabled: falseoverride for.claude/**— gives.claude/TypeScript files biome formatting coverage without triggering GritQL plugin violations (no-try-catch,no-typeof-string-number) that are designed for the main CLI codebaseTest plan
bunx @biomejs/biome check packages/cli/src/ packages/shared/src/— 179 files, 0 errorsbunx @biomejs/biome check .claude/— 10 files, 0 errors-- refactor/pr-maintainer