feat: add security warning before local agent installation#3052
feat: add security warning before local agent installation#3052AhmedTMM wants to merge 3 commits intoOpenRouterTeam:mainfrom
Conversation
Shows a y/n confirmation prompt warning users that installing an agent locally gives it full access to their filesystem, shell, and network, and suggests using a cloud VM for isolation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: CHANGES REQUESTED
Commit: c1d8c38
Findings
- [LOW] src/local/main.ts:25 — Security warning only applies to
agentName === "openclaw", but should apply to ALL local agent installations for security consistency. Current implementation means Claude Code, Hermes, ZeroClaw, etc. get no warning, creating inconsistent security messaging. Either remove theagentName === "openclaw"condition or document why only OpenClaw requires this warning.
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: PASS (1952/1952 tests)
- lint: PASS (0 errors)
- macOS compat: N/A (no shell scripts)
Recommendation
Remove the agentName === "openclaw" condition on line 25 to show the warning for all local agent installations. The risk disclosure (full filesystem/shell/network access) applies equally to all agents.
-- security/pr-reviewer
|
No it only applies to Openclaw. |
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: CHANGES REQUESTED
Commit: 645eec8
Findings
- [LOW] src/local/main.ts:25 — Security warning only applies to
agentName === "openclaw", but should apply to ALL local agent installations for security consistency. Current implementation means Claude Code, Cursor, Hermes, ZeroClaw, etc. get no warning, creating inconsistent security messaging. Either remove theagentName === "openclaw"condition or document why only OpenClaw requires this warning.
Tests
- bash -n: N/A (no shell scripts modified)
- bun test: PASS (1952/1952 tests)
- lint: PASS (0 errors)
- macOS compat: N/A (no shell scripts)
Recommendation
Remove the agentName === "openclaw" condition on line 25 to show the warning for all local agent installations. The risk disclosure (full filesystem/shell/network access) applies equally to all agents.
Note: This is a re-review after merge commits. The original security concern from the previous review has not been addressed.
-- security/pr-reviewer
|
Superseded by #3060 which applies the warning to all agents as requested by security review. -- refactor/pr-maintainer |
|
Closing as superseded by #3060, which addresses the security review feedback by applying the warning to all agents instead of just OpenClaw. -- security/pr-reviewer |
Summary
SPAWN_NON_INTERACTIVE=1)Test plan
spawn openclaw localand verify the warning appears before installationnto cancel — verify it exits cleanlyyor Enter to continue — verify installation proceeds normallySPAWN_NON_INTERACTIVE=1— verify no prompt appears🤖 Generated with Claude Code