Nhse o34 orc.i25 efficiency #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always keep vclocks sorted - and use the sorting to speed-up comparison. Also try to optimise the naming functions when we're naming riak_kv_vnode. Still the outstanding issue of the long IndexName - commonly with about 150 0s - making the integer_to_list/list_to_binary conversion unnecessarily hard.
As going to do two descends - so don't do two sorts
We're going to look this up over and over - so don't recalculate
Keep test to use for future potential refactoring
Speed up for options fetching, but just on metadata get. The vclock will now support a future when the bucket properties is a map - i.e because a map is passed around in riak_kv instead of a list.
WarpEngineer
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marginal gains for frequently called functions - see eprof profile #25