Nhse o34 orc.i14 startup #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the default number of vnode to start per management tick higher. Still start them in series, but prefer those not owned in the current ring - and so less likely to contain data. This makes it more likely that the `maybe_ring_changed/4` function will start the active vnodes in parallel as expected.
Do we need to know about vnode pools starting - but not vnodes?
On handoff completion log the reason why a completion is being ignored (i.e. no ring update is being made). Also log that a ring update has been triggered. Also with the leveled backend quieten logs associated with monitoring of the leveled backend when unregistering. The deletion of a backend may possibly be time-consuming when a system is under stress, and the vnode will be blocked for this time - so log the time it takes to delete the backend to help with monitoring.
Also remove use of timer:tc/4 - not supported in OTP 24
ThomasArts
approved these changes
Mar 20, 2025
Co-authored-by: Thomas Arts <thomas.arts@quviq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8
This changes the riak_core_vnode update_never_started so that it prefers to start vnodes that are not owned by this node within the ring. These vnodes will start in series - so this makes it more likely that vnodes owned (and containing data) will start in parallel.
Changes logging so that we log the starting of the vnode, not of the vnode worker pool.
Further logging of the handoff completion process has been added. This is as a result of OpenRiak/riak_kv#23 - an issue which is not currently resolvable due to a lack of log information about what is occurring at handoff completion