This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Open
Conversation
Add back ability to set default template
Author
|
It might be preferable to simply make the type of the This would make it easy to add further functions for processing configuration, without having to update the main Riak repo. |
Member
|
Perhaps rather than specifying a function name, we specify a module name (conforming to a behavior). This would alter some of my comments on OpenRiak/riak_logger#1 ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional config for logs, plus also a config item
logger.config_function.The
logger.config_functioncan be mapped to a logger config function using the case statement:https://github.com/OpenRiak/riak/blob/66cdea92c376824e5a773c1453ee8f534ed2e86d/priv/riak.schema#L115-L125
There are two logger config functions that have been added to riak_logger - one to produce logs as they were in
openriak-3.2, and another to produce as proposed foropenriak-3.4.