Add Unit Tests for Experiment Model and ParameterManager #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for ParameterManager Co-authored-by: Genie <genie@cosine.sh>
Co-authored-by: Genie <genie@cosine.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive unit tests for the
Experimentmodel andParameterManagerclass. The newly created tests significantly increase the overall coverage rate of the codebase by validating key functionalities such as managing paramsets, preserving state through YAML files, and handling legacy parameter formats. Additionally, both splitter and non-splitter modes are tested for target filename generation, ensuring accurate behavior in diverse scenarios. All tests are well-documented to clarify their purpose and expected outcomes.Original Task: pyptv/ddkf8qom16h9
Author: Alex Liberzon