Skip to content

Conversation

@ice-tong
Copy link
Contributor

@ice-tong ice-tong commented Aug 22, 2024

Motivation

The difference between max/min and amax/amin is:

  • amax/amin supports reducing on multiple dimensions,
  • amax/amin does not return indices,
  • amax/amin evenly distributes gradient between equal values, while max(dim)/min(dim) propagates gradient only to a single index in the source tensor.

Modification

  • ppq/executor/op/torch/default.py
    • Use torch.amax in ReduceMax forward to support multiplie dim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant