Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves site performance, font loading reliability, and accessibility for the SRCCON Jekyll site. It activates GA4 analytics tracking, upgrades newsletter links from HTTP to HTTPS, enhances Typekit font loading with fallback logic and a timeout, adds explicit image dimensions to reduce Cumulative Layout Shift, preloads the main logo image, and cleans up dead/empty CSS rules.
Changes:
- Enabled GA4 analytics tracking by setting
google_analytics_idin_config.yml, and improved Typekit font loading inheadmeta.htmlwith a 1.2s timeout, class-based events, and CSS fallback rules instyle.css - Added explicit
width/heightattributes to logo and sponsor images across both layout files, and added a<link rel="preload">for the logo inlayout_hub.html - Upgraded newsletter links from HTTP to HTTPS in
homepage.mdand cleaned up empty CSS rule blocks and a duplicate color declaration
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
_config.yml |
Activates GA4 tracking with measurement ID G-W7QDZ6VHC9 |
homepage.md |
Upgrades eepurl.com newsletter links from HTTP to HTTPS |
_layouts/layout_hub.html |
Adds logo preload hint and explicit width/height on logo <img> |
_layouts/layout.html |
Adds explicit width/height to logo and all sponsor <img> elements |
_includes/headmeta.html |
Enhances Typekit loading with scriptTimeout, class events, and fonts-fallback-locked callback |
media/css/style.css |
Adds font fallback rules for wf-loading/wf-inactive/fonts-fallback-locked states; removes empty rules and duplicate color: silver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AI summary] This pull request introduces several improvements to site performance, accessibility, and font loading reliability, along with minor content and style updates. The most significant changes include enhanced font loading fallbacks, explicit image sizing for faster rendering, and improved sponsor logo accessibility. Additionally, Google Analytics tracking is enabled and some minor link and style adjustments are made.
[Tiff list]
google_analytics_idwidthandheightattributes to all major images_layouts/layout_hub.htmlfor faster initial load_includes/headmeta.htmlby adding fallback logic and timeout, and updating the CSS inmedia/css/style.cssto use fallback fonts if Typekit fails or is slow to load