Skip to content

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github May 7, 2025

Updates the requirements on tensordict to permit the latest version.

Release notes

Sourced from tensordict's releases.

v0.8.2: Fix memory leakage due to validate

This release fixes an apparent memory leak due to the value validation in tensordict. The leak is apparent, as in it disappears in gc.collect() is invoked. See #1309 for context.

Full Changelog: pytorch/tensordict@v0.8.1...v0.8.2

Commits
  • f25e61f Ninja build
  • a328b5e [Performance] Second attempt at caching validation
  • e80c97a Versioning
  • 48031c6 [BugFix] Fix mem leak caused by _validate_value
  • 554308a version bump
  • a873560 [Setup] statically link _C extension against the Python library
  • e84d44f [Setup] Better version check in smoke_test.py
  • 2267ceb [Setup] Fix versioning in CI
  • 769f996 [Setup] Fix version import
  • 82744de [CI] Fix nightly version
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Kunlun-Zhu and others added 23 commits April 16, 2025 22:01
Test pipeline add first version
* openmanus-0.01

* agentgym input process

* add gitignore

* adding pipeline description docs
* openmanus-0.01

* agentgym input process

* add gitignore

* adding pipeline description docs

* Fix multi-server parallel support

* adding initial testing
* fix(train_ppo): 使用 setsid 和 kill PGID 改进后台服务器清理

- 使用 `setsid` 在独立的进程组中启动 AgentGym 服务器。这确保了由 `conda run` 启动的所有子进程都属于同一个组。
- 修改 `trap EXIT` 清理逻辑,使用 `kill -- -PGID` 杀死整个进程组,而不是仅杀死初始的 `conda run` PID。这样可以更可靠地终止服务器及其所有潜在的子进程。
- 将存储的 ID 从 PID 改为 PGID。
- 移除了之前检查服务器进程是否存在的逻辑,因为 `setsid` 很快退出,该检查不再可靠。

此更改解决了主脚本退出时 AgentGym 服务器可能由于信号未通过 `conda run` 正确传播而无法正确终止的问题。

TODO: 检查 train_grpo.sh 并应用类似的服务端清理逻辑。

* fix(train_ppo): 改进 AgentGym 服务器管理和启动检查
- **新增基于网络端口 (`nc`) 的服务器启动检查逻辑,替代原先不可靠的 PID 检查。**
- 实现端口检查的重试机制,并在检查失败时触发清理并退出。

---------

Co-authored-by: chenzp15 <chenzp15@lenovo.com>
* fix(train_ppo): 使用 setsid 和 kill PGID 改进后台服务器清理

- 使用 `setsid` 在独立的进程组中启动 AgentGym 服务器。这确保了由 `conda run` 启动的所有子进程都属于同一个组。
- 修改 `trap EXIT` 清理逻辑,使用 `kill -- -PGID` 杀死整个进程组,而不是仅杀死初始的 `conda run` PID。这样可以更可靠地终止服务器及其所有潜在的子进程。
- 将存储的 ID 从 PID 改为 PGID。
- 移除了之前检查服务器进程是否存在的逻辑,因为 `setsid` 很快退出,该检查不再可靠。

此更改解决了主脚本退出时 AgentGym 服务器可能由于信号未通过 `conda run` 正确传播而无法正确终止的问题。

TODO: 检查 train_grpo.sh 并应用类似的服务端清理逻辑。

* fix(train_ppo): 改进 AgentGym 服务器管理和启动检查
- **新增基于网络端口 (`nc`) 的服务器启动检查逻辑,替代原先不可靠的 PID 检查。**
- 实现端口检查的重试机制,并在检查失败时触发清理并退出。

---------

Co-authored-by: chenzp15 <chenzp15@lenovo.com>
* adding new reward & delete unused modules

* Fix/agentgym server cleanup (#53)

* fix(train_ppo): 使用 setsid 和 kill PGID 改进后台服务器清理

- 使用 `setsid` 在独立的进程组中启动 AgentGym 服务器。这确保了由 `conda run` 启动的所有子进程都属于同一个组。
- 修改 `trap EXIT` 清理逻辑,使用 `kill -- -PGID` 杀死整个进程组,而不是仅杀死初始的 `conda run` PID。这样可以更可靠地终止服务器及其所有潜在的子进程。
- 将存储的 ID 从 PID 改为 PGID。
- 移除了之前检查服务器进程是否存在的逻辑,因为 `setsid` 很快退出,该检查不再可靠。

此更改解决了主脚本退出时 AgentGym 服务器可能由于信号未通过 `conda run` 正确传播而无法正确终止的问题。

TODO: 检查 train_grpo.sh 并应用类似的服务端清理逻辑。

* fix(train_ppo): 改进 AgentGym 服务器管理和启动检查
- **新增基于网络端口 (`nc`) 的服务器启动检查逻辑,替代原先不可靠的 PID 检查。**
- 实现端口检查的重试机制,并在检查失败时触发清理并退出。

---------

Co-authored-by: chenzp15 <chenzp15@lenovo.com>

* fix config bugs

* .

* .

---------

Co-authored-by: rxdaozhang <37535540+rxdaozhang@users.noreply.github.com>
Co-authored-by: chenzp15 <chenzp15@lenovo.com>
* debug gpu issues

* fix flashattention 2 issues for float32

* fix gae issues

* debug worker initialize problems

* update debug info

* fix bugs on the actor critic data split in gpu
Co-authored-by: Zhu <kunlunz2@cc-login2.campuscluster.illinois.edu>
Updates the requirements on [tensordict](https://github.com/pytorch/tensordict) to permit the latest version.
- [Release notes](https://github.com/pytorch/tensordict/releases)
- [Commits](pytorch/tensordict@0.0.1b...v0.8.2)

---
updated-dependencies:
- dependency-name: tensordict
  dependency-version: 0.8.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels May 7, 2025
@realtmxi realtmxi force-pushed the dependabot/pip/tensordict-lt-0.9 branch from fea2230 to d34effd Compare May 23, 2025 10:51
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 7, 2025

A newer version of tensordict exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants