New Setting to make Profile Public, new UserSettings table#314
Open
New Setting to make Profile Public, new UserSettings table#314
Conversation
# Conflicts: # .idea/olm.iml # .idea/php.xml # app/Http/Controllers/User/ProfileController.php # composer.lock # public/js/app.js # public/mix-manifest.json # resources/js/components/Profile/middle/ProfileMap.vue # resources/js/store/modules/user/index.js # resources/js/store/modules/user/mutations.js
Collaborator
|
I propose we use a package to handle user settings. This is both for new settings added and migrating the old ones. Having them as database columns makes it pretty hard to update them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are changing the design of the users profile page
and introduce a new setting to make it public or private.
If the setting is public, anyone can visit openlittermap.com/username to see the users profile and interact with their data.
The user can show their rank, total images, total litter and total categories
We have another setting to view map + download data.
If we give the viewer the ability to view the map data, we are essentially giving them the ability to download the data so I think we need to group these together to be clear about it
Any comments or suggestions?