[WIP] testing whether integration-tests as module works for plugins#1708
Draft
bmarwell wants to merge 1 commit intoOpenLiberty:mainfrom
Draft
[WIP] testing whether integration-tests as module works for plugins#1708bmarwell wants to merge 1 commit intoOpenLiberty:mainfrom
bmarwell wants to merge 1 commit intoOpenLiberty:mainfrom
Conversation
bmarwell
force-pushed
the
integration_test_as_module
branch
2 times, most recently
from
95b923d to
50f1c30
Compare
[WIP] remove extension from IT, allow skipping main ITs
bmarwell
force-pushed
the
integration_test_as_module
branch
from
50f1c30 to
d4ea138
Compare
Contributor
|
I like the idea of bypassing the invoker:run execution (but still using invoker:install to run against the just-built-plugin). It seems like there's some work ahead though. I found a gotcha even in the LibertySettingsDirectoryTest in config-directory-it. Even though you're trying to bypass running with the invoker plugin the test Java itself is making an invoker call ! I think I fixed or bypassed it here 84a5a10 but maybe it shows there's a good amount of porting work potentially to take this to completion. I like the fact that we'd no longer rely on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip "default" ITs using:
Odd, but clean is needed b/c of the duplicate plugin descriptor.