Skip to content

Update the output from generate features task #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
turkeylurkey wants to merge 2 commits into
base: generate-features-update
Choose a base branch
from
Draft

Update the output from generate features task #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98c78b7
Update the output from generate features task
turkeylurkey May 14, 2025
4b51784
Update dev mode test for generate features message
turkeylurkey Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/groovy/io/openliberty/tools/gradle/tasks/GenerateFeaturesTask.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,12 @@ class GenerateFeaturesTask extends AbstractFeatureTask {
configDocument.createFeature(missing);
}
// Generate log message before writing file as the file change event kicks off other dev mode actions
logger.lifecycle("Generated the following features: " + missingLibertyFeatures);
logger.lifecycle("Generated the features " + missingLibertyFeatures + " in the file " + newServerXmlSrc.getAbsolutePath());
// use logger.lifecycle so that message appears without --info tag on
configDocument.writeXMLDocument(newServerXmlSrc);
logger.debug("Created file " + newServerXmlSrc);
} else {
logger.lifecycle("Regenerated the following features: " + missingLibertyFeatures);
logger.lifecycle("Generated the features " + missingLibertyFeatures + " and confirmed they exist in the file: " + newServerXmlSrc.getAbsolutePath());
// use logger.lifecycle so that message appears without --info tag on
}
} else {
Expand Down
4 changes: 2 additions & 2 deletions src/test/groovy/io/openliberty/tools/gradle/BaseDevTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ class BaseDevTest extends AbstractIntegrationTest {
static String buildFilename = "build.gradle";
final String RUNNING_INSTALL_FEATURE = "Task :installFeature";
final String RUNNING_GENERATE_FEATURES = "Task :generateFeatures";
final String REGENERATE_FEATURES = "Regenerated the following features:";
final String GENERATE_FEATURES = "Generated the following features:";
final String REGENERATE_FEATURES = "and confirmed they exist in the file: ";
final String GENERATE_FEATURES = " in the file ";
final String GENERATED_FEATURES_FILE_NAME = "generated-features.xml";
final String SERVER_XML_COMMENT = "Plugin has generated Liberty features"; // the explanation added to server.xml
final String NEW_FILE_INFO_MESSAGE = "This file was generated by the Liberty Gradle Plugin and will be overwritten"; // the explanation added to the generated features file
Expand Down