Fixed the wrong toolchain honored log#1062
Merged
venmanyarun merged 4 commits intoOpenLiberty:mainfrom Feb 26, 2026
Conversation
Contributor
|
please add tests for this scenario, making sure no logs has been printed.. |
… and isJavaHomeSetForJvmOptions() are called before loading config from properties
cherylking
requested changes
Feb 23, 2026
src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
Outdated
Show resolved
Hide resolved
…warnings on scenarios like java home configured in JVM Options and Server Env Test
Contributor
Author
Added tests |
cherylking
requested changes
Feb 24, 2026
src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
Outdated
Show resolved
Hide resolved
Contributor
Author
TestingBefore fixing:Screen.Recording.2026-02-24.at.12.00.11.PM.movAfter fixing:Screen.Recording.2026-02-24.at.12.02.20.PM.mov |
cherylking
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1061
Added check for JAVA_HOME in server.env while logging the Toolchain honored information in DevTask.goovy:compile()