Caching the resolved JDK home path on once successfully resolved#1058
Merged
venmanyarun merged 2 commits intoOpenLiberty:mainfrom Feb 19, 2026
Conversation
venmanyarun
requested changes
Feb 18, 2026
cherylking
reviewed
Feb 18, 2026
src/main/groovy/io/openliberty/tools/gradle/tasks/AbstractLibertyTask.groovy
Show resolved
Hide resolved
cherylking
approved these changes
Feb 18, 2026
venmanyarun
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1057
Root Cause: getToolchainJavaHome() returned null when dev mode stops because getJavaToolchainService().launcherFor(toolchain) is a lazy provider, resolving it requires Gradle's build operation context, which is only bound to the @TaskAction thread. The stop is triggered from DevUtil's key reader thread, which has no build operation context, causing "IllegalStateException: No current build operation" and then returns null.
Fix: Cache the resolved JDK home path on once successfully resolved. All the other calls returns the cached value directly.