h3c-tc2101 still needs the legacy sigmastar-motors #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: OpenIPC/firmware@6b5b479bfec1 ("[no ci] Package: move motor sample to legacy (#1857)")
The new introduced 'gpio-motors' does not support the way how h3c-tc2101 controls its motors. Let's fallback to use the *legacy* code and pretent we are the new one. Fixes: 1a48cb2 ("Set as default gpio-motors package")
…TORS Fixes: 1a48cb2 ("Set as default gpio-motors package")
flyrouter
reviewed
Jan 13, 2026
Member
flyrouter
left a comment
flyrouter
left a comment
There was a problem hiding this comment.
Good afternoon
Thank you for your interest in our project
The gpio-motors package is intended to replace all other options for experiments with motors controlled via GPIO (sigmastar-motors, goke-motors, xm-motors, hisilicon-motors, and others).
The right approach is to achieve adaptation on a universal solution.
Please consider this so that we can reach a consensus.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new introduced 'gpio-motors' does not support the way how h3c-tc2101 controls its motors.
Let's fallback to use the legacy code and pretent we are the new one.