Skip to content

Conversation

@andreacasarin
Copy link

@andreacasarin andreacasarin commented Oct 24, 2025


name: 🔄 Removing unused directive breaking eslint
about: Fixing the main build via Docker #97

What's changed?

Just removed the // @ts-expect-error from middleware.ts which was breaking eslint and the whole build.

✨ Screenshots (optional)

Screenshot 2025-10-24 at 15 31 50

@gemini-code-assist
Copy link

Summary of Changes

Hello @andreacasarin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build failure by removing an extraneous TypeScript directive. The removal of an unused // @ts-expect-error comment in src/middleware.ts ensures that ESLint functions correctly, thereby restoring the stability and integrity of the build process.

Highlights

  • ESLint Fix: Removed an unused // @ts-expect-error directive from src/middleware.ts.
  • Build Stability: This change resolves an issue where ESLint was breaking the build process due to the aforementioned directive.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes an unused @ts-expect-error directive that was causing a build failure. I've added one suggestion to also remove the now-redundant eslint-disable-next-line comment for better code hygiene.


const signInPathName = '/login';

// eslint-disable-next-line @typescript-eslint/ban-ts-comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that the // @ts-expect-error directive on the next line has been removed, this eslint-disable-next-line comment is no longer necessary and can also be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant