Fix flaky tests in LongConvertorFieldsTest by removing dependence on field orde… #1239
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbh930
force-pushed
the
fix_long_convertor_fields_test
branch
from
8fc540e to
6523ece
Compare
Author
|
I updated the PR to make the changes smaller. |
lbh930
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
LongConvertorFieldsTest.javato sort the serialized fields before comparing them with the expected output. This ensures that the test is deterministic and doesn't depend on the iteration order ofClass.getDeclaredFields()which don't have guarantee in consistency.Motivation
NonDex detected test flakiness in 5 tests:
net.openhft.chronicle.wire.converter.LongConvertorFieldsTest.base16net.openhft.chronicle.wire.converter.LongConvertorFieldsTest.base64net.openhft.chronicle.wire.converter.LongConvertorFieldsTest.base85net.openhft.chronicle.wire.converter.LongConvertorFieldsTest.shortTextnet.openhft.chronicle.wire.converter.LongConvertorFieldsTest.wordsThis PR is verified by NonDex to fix them all. The root cause was that the tests asserted a specific order of fields in the serialized YAML string. Since
SelfDescribingMarshallableuses reflection to discover fields, the order is not guaranteed. An example of NonDex output with detected test failure is attached.nondex_output.txt