-
Notifications
You must be signed in to change notification settings - Fork 3
Organize tyk2 test data #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 86.86% 87.30% +0.44%
==========================================
Files 11 14 +3
Lines 1439 1552 +113
==========================================
+ Hits 1250 1355 +105
- Misses 189 197 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikemhenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question about pytest_plugins = ["feflow.tests.fixtures.tyk2_fixtures"] since I haven't seen it before
|
|
||
| from feflow.tests.conftest import solvent_comp | ||
| # required plugins/fixtures | ||
| pytest_plugins = ["feflow.tests.fixtures.tyk2_fixtures"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It basically just adds the fixtures/objects in that module to the current scope. I'm using it instead of having all the fixtures in the conftest.py file or something like that, which was the previous case and it was getting a little too big and hard to handle that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it would be equivalent to importing all from that module
This set of changes aim to organize the test data for tyk2 which was in two different places and now it's in the same subdirectory, avoiding redundant data for the main PDB protein file, and hopefully achieving a more organized way. A fixtures modules for the tyk2 data is also implemented to help organization.