Skip to content

Conversation

@ijpulidos
Copy link
Contributor

This set of changes aim to organize the test data for tyk2 which was in two different places and now it's in the same subdirectory, avoiding redundant data for the main PDB protein file, and hopefully achieving a more organized way. A fixtures modules for the tyk2 data is also implemented to help organization.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.30%. Comparing base (639b258) to head (5fcaa89).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   86.86%   87.30%   +0.44%     
==========================================
  Files          11       14       +3     
  Lines        1439     1552     +113     
==========================================
+ Hits         1250     1355     +105     
- Misses        189      197       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ijpulidos ijpulidos requested a review from mikemhenry December 29, 2025 21:17
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question about pytest_plugins = ["feflow.tests.fixtures.tyk2_fixtures"] since I haven't seen it before


from feflow.tests.conftest import solvent_comp
# required plugins/fixtures
pytest_plugins = ["feflow.tests.fixtures.tyk2_fixtures"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It basically just adds the fixtures/objects in that module to the current scope. I'm using it instead of having all the fixtures in the conftest.py file or something like that, which was the previous case and it was getting a little too big and hard to handle that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be equivalent to importing all from that module

@ijpulidos ijpulidos merged commit 8eb1b3c into main Dec 29, 2025
6 checks passed
@ijpulidos ijpulidos deleted the tests/remove-redundant-data branch December 29, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants