Skip to content

Conversation

@ijpulidos
Copy link
Contributor

These changes would provide the protein mutation capabilities to the current NonEquilibriumCycling protocol. This is thought as a feature branch, that way other changes would be merged into protein-mutation-protocol first before this one gets merged into main.

ijpulidos and others added 13 commits August 15, 2024 17:49
* Neutral protein mutation convergence test

* Charge changing protein mutation convergence test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Using GUFE's JSON decoder

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Using forward-reverse utility function in all tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Custom exceptions for unsupported operations
* Failure test for unsupported PRO transformation
* Double charge expected fail test
Added protein mutation support for setup unit as well as testing and tutorial. All within the same nonequilibrium cycling protocol.
@ijpulidos ijpulidos marked this pull request as ready for review December 19, 2025 21:44
@ijpulidos
Copy link
Contributor Author

ijpulidos commented Dec 19, 2025

Just wanted to say that most of the changes here are pre-approved from #106 . They are squashed in a single commit so it should be fairly easy to tell which changes are unique to this PR.

@ijpulidos ijpulidos requested a review from IAlibay December 19, 2025 21:49
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 93.88889% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.30%. Comparing base (639b258) to head (e18af6a).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
feflow/utils/vendored.py 89.06% 7 Missing ⚠️
feflow/protocols/nonequilibrium_cycling.py 96.42% 3 Missing ⚠️
feflow/utils/misc.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   86.86%   87.30%   +0.44%     
==========================================
  Files          11       14       +3     
  Lines        1439     1552     +113     
==========================================
+ Hits         1250     1355     +105     
- Misses        189      197       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had a very brief look, but this seems good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants