Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 4, 2025

I'm adding any generated files to the git ignore to avoid committing large files by mistake (me? never.)

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Colab 👈 Launch a Colab session on branch maint/update_git_ignore

@atravitz atravitz marked this pull request as ready for review December 4, 2025 21:25
@atravitz atravitz requested a review from mikemhenry December 4, 2025 21:25
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, we do want to track any additions / changes to the core PDB files under cookbook/assests/of3_output, but we don't want to track the additional directories being created. It might be that we have to change the notebook to write to a different location.

.gitignore Outdated
abfe_tutorial/abfe_results/
abfe_tutorial/abfe_json/
ahfe_tutorial/ahfe_json/
cookbook/assets/of3_output/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PDBs under this section are ones we want to keep track of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this! I updated it to specifically ignore of3_output/p_aligned and of3_output/temp_ligands.

@atravitz atravitz requested a review from IAlibay December 9, 2025 20:16
@atravitz atravitz merged commit 7661d0d into main Dec 10, 2025
4 checks passed
@atravitz atravitz deleted the maint/update_git_ignore branch December 10, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants