Skip to content

Conversation

@atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 3, 2025

resolves #251

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Colab 👈 Launch a Colab session on branch maint/delete_unused_nbs

@atravitz atravitz requested a review from IAlibay December 3, 2025 21:48
@atravitz
Copy link
Contributor Author

atravitz commented Dec 3, 2025

tests are failing for reasons that will be addressed in #268

@atravitz atravitz merged commit 7612df5 into main Dec 3, 2025
2 of 6 checks passed
@atravitz atravitz deleted the maint/delete_unused_nbs branch December 3, 2025 21:54
@dwhswenson
Copy link
Member

@atravitz @IAlibay This change means that installs of OpenFE without OpenFreeEnergy/openfe#1732 fail when running openfe test (and I don't think that PR has been included in a release yet). Can we either temporarily resurrect these notebooks or cut a patch release? Someone following the OpenFE install instructions will currently get failing tests. (Getting this on AMI builds now.)

@atravitz
Copy link
Contributor Author

atravitz commented Dec 8, 2025

@dwhswenson yes we're aware of this and we're cutting a v1.8.0 release today. fetch rbfe-showcase isn't anywhere in our user-facing functionality, but I realize failing tests is a nuisance. is resolving this within 24 hours okay for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused / outdated notebooks under openmm_rbfe

4 participants