#31 ✨ feat: wrap execDdev command with XDEBUG_MODE=off #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves how shell commands are executed within the
DdevUtilsutility class to ensure that the Xdebug extension is disabled during execution, which helps prevent issues with command hanging or slowness. It also adds tests to verify the new behavior, including proper escaping of single quotes in commands.Command execution improvements:
execDdevmethod inDdevUtilsto wrap commands withbash -c 'XDEBUG_MODE=off ...'so that Xdebug is disabled during execution, and added logic to escape single quotes in the command for safe shell execution.isToolInstalledand tool validation logic to use the updatedexecDdevmethod instead of directly callingexecSync, ensuring consistent behavior and Xdebug handling. [1] [2]Testing improvements:
execDdevwraps commands correctly withXDEBUG_MODE=offand that single quotes in commands are properly escaped.