Added some new Professional LAB and SmartPrint Filaments #140
Conversation
There was a problem hiding this comment.
Pull request overview
This PR claims to add new filament variants for Professional LAB and SmartPrint brands, but upon detailed review, all files in this PR already exist in the repository with identical content. The PR contains approximately 200+ files across multiple filament types (pla_silk, pla_silk_dual, pla_silk_tri, pla_meta, hs_pla, and pla_cf), but every single file is a duplicate that would simply overwrite existing files.
Changes:
- Attempts to add ~100 SmartPrint filament variants across 5 filament types (hs_pla, pla_silk, pla_meta, pla_silk_dual, pla_silk_tri)
- Attempts to add ~100 Professional LAB filament variants across 6 filament types (hs_pla, pla_silk, pla_meta, pla_silk_dual, pla_silk_tri, pla_cf)
- Includes 6 filament.json files that already exist
Reviewed changes
Copilot reviewed 196 out of 196 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| data/smartprint/PLA/pla_silk_tri/* | All 10 variants and filament.json already exist - duplicates |
| data/smartprint/PLA/pla_silk_dual/* | All 9 variants and filament.json already exist - duplicates |
| data/smartprint/PLA/pla_silk/* | All 12 variants already exist - duplicates |
| data/smartprint/PLA/pla_meta/* | All 7 variants and filament.json already exist - duplicates |
| data/smartprint/PLA/hs_pla/* | All 9 variants already exist - duplicates |
| data/professional_lab/PLA/pla_silk_tri/* | All 10 variants and filament.json already exist - duplicates |
| data/professional_lab/PLA/pla_silk_dual/* | All 9 variants and filament.json already exist - duplicates |
| data/professional_lab/PLA/pla_silk/* | All 12 variants already exist - duplicates |
| data/professional_lab/PLA/pla_meta/* | All 7 variants and filament.json already exist - duplicates |
| data/professional_lab/PLA/hs_pla/* | All 9 variants already exist - duplicates |
| data/professional_lab/PLA/pla_cf/green/* | Variant already exists - duplicate |
| { | ||
| "id": "pla_silk_tri", | ||
| "name": "PLA Silk Tri", | ||
| "diameter_tolerance": 0.03, | ||
| "density": 1.24, | ||
| "max_dry_temperature": 50 | ||
| } |
There was a problem hiding this comment.
This filament.json file already exists in the repository. The existing file has identical content, so this addition would simply overwrite the existing file with the same data. This filament.json file should be removed from this PR as it's unnecessary duplication.
| { | ||
| "id": "pla_silk_tri", | ||
| "name": "PLA Silk Tri", | ||
| "diameter_tolerance": 0.03, | ||
| "density": 1.24, | ||
| "max_dry_temperature": 50 | ||
| } |
There was a problem hiding this comment.
This filament.json file already exists in the repository. The existing file has identical content, so this addition would simply overwrite the existing file with the same data. This filament.json file should be removed from this PR as it's unnecessary duplication.
| { | ||
| "id": "pla_silk_dual", | ||
| "name": "PLA Silk Dual", | ||
| "diameter_tolerance": 0.03, | ||
| "density": 1.24, | ||
| "max_dry_temperature": 50 | ||
| } |
There was a problem hiding this comment.
This filament.json file already exists in the repository. The existing file has identical content, so this addition would simply overwrite the existing file with the same data. This filament.json file should be removed from this PR as it's unnecessary duplication.
| { | ||
| "id": "black", | ||
| "name": "Black", | ||
| "color_hex": [ | ||
| "#000000" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
All Professional LAB PLA Meta variants in this PR already exist in the repository with identical content. These files (yellow, white, red, green, gray, blue, black variants and their sizes.json files) are unnecessary duplicates that would simply overwrite existing files. They should all be removed from this PR.
| { | |
| "id": "black", | |
| "name": "Black", | |
| "color_hex": [ | |
| "#000000" | |
| ] | |
| } |
| { | ||
| "id": "pla_meta", | ||
| "name": "PLA Meta", | ||
| "diameter_tolerance": 0.03, | ||
| "density": 1.25, | ||
| "max_dry_temperature": 50 | ||
| } |
There was a problem hiding this comment.
This filament.json file already exists in the repository. The existing file has identical content, so this addition would simply overwrite the existing file with the same data. This filament.json file should be removed from this PR as it's unnecessary duplication.
| { | ||
| "id": "green", | ||
| "name": "Green", | ||
| "color_hex": [ | ||
| "#669c35" | ||
| ], | ||
| "traits": { | ||
| "contains_carbon_fiber": true | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
The PLA-CF green variant already exists in the repository with identical content. This file and its corresponding sizes.json are unnecessary duplicates that would simply overwrite existing files. They should be removed from this PR.
| { | |
| "id": "green", | |
| "name": "Green", | |
| "color_hex": [ | |
| "#669c35" | |
| ], | |
| "traits": { | |
| "contains_carbon_fiber": true | |
| } | |
| } |
| { | ||
| "id": "pla_meta", | ||
| "name": "PLA Meta", | ||
| "diameter_tolerance": 0.03, | ||
| "density": 1.25, | ||
| "max_dry_temperature": 50 | ||
| } |
There was a problem hiding this comment.
This filament.json file already exists in the repository. The existing file has identical content, so this addition would simply overwrite the existing file with the same data. This filament.json file should be removed from this PR as it's unnecessary duplication.
| { | ||
| "id": "black", | ||
| "name": "Black", | ||
| "color_hex": [ | ||
| "#000000" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
All SmartPrint PLA Silk variants in this PR already exist in the repository with identical content. These files (yellow, white, transparent, silver, rainbow, purple, green, gold, glamour, copper, brass, black variants and their sizes.json files) are unnecessary duplicates that would simply overwrite existing files. They should all be removed from this PR.
| { | ||
| "id": "army", | ||
| "name": "Army", | ||
| "color_hex": [ | ||
| "#9aa60e", | ||
| "#e4ef65", | ||
| "#fffc41" |
There was a problem hiding this comment.
All SmartPrint PLA Silk Tri variants in this PR already exist in the repository with identical content. These files (sunset_horizon, storms_whisper, royal_blossom, red_yellow_green, red_blue_green, orange_blue_green, blue_purple_black, blue_green_purple, black_gold_purple, army variants and their sizes.json files) are unnecessary duplicates that would simply overwrite existing files. They should all be removed from this PR.
| { | ||
| "id": "black", | ||
| "name": "Black", | ||
| "color_hex": [ | ||
| "#000000" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
All Professional LAB PLA Silk variants in this PR already exist in the repository with identical content. These files (yellow, white, transparent, silver, rainbow, purple, green, gold, glamour, copper, brass, black variants and their sizes.json files) are unnecessary duplicates that would simply overwrite existing files. They should all be removed from this PR.
|
Seems there's a few issues Clippy's identitied but decided not to show in the chat, I do concur with its conclusions, if you could please look through the files tab and rectify its issues we'll get you merged soon as possible :D |
I don’t really get what he means with every added variant “already exists” 😄 I added them myself today in a freshly sync fork 😄 |
2 participants
No description provided.