OpenRing: support payload-based commands and enable PPG waveform streaming#112
Merged
TobiasRoeddiger merged 13 commits intoopen-ringfrom Feb 11, 2026
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 1ec726f): https://open-earable-lib-web-example--pr112-codex-update-code-l9la8h02.web.app (expires Wed, 11 Mar 2026 09:28:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
0x32) requires a multi-byte payload to enable continuous waveform streaming instead of a single sub-opcode.subOpcodebyte which cannot express the required PPG payload parameters.Description
subOpcodewith aList<int> payloadinOpenRingSensorConfigurationValueand updated the configuration wiring to pass the payload when applying a configuration (file:lib/src/models/capabilities/sensor_configuration_specializations/open_ring_sensor_configuration.dart).OpenRingSensorConfigto carry aList<int> payloadand changedtoBytes()to serialize commands as the framed packet[0x00, <seq>, <cmd>, ...payload](file:lib/src/managers/open_ring_sensor_handler.dart).00 <seq> 32 00 00 19 01 01semantics and the "Off" payload sends the corresponding stop payload (file:lib/src/models/devices/open_ring_factory.dart).Testing
rg -n "OpenRingSensorConfig\(|OpenRingSensorConfigurationValue\(" lib/src -Sto confirm usages were updated and this check succeeded.git diff --checkand static checks with no reported issues.dart format/flutter formatfor automatic formatting but those tools were not available in the environment, so formatting checks were not executed.Codex Task