od: Avoid subshell in rcS and rcK #104
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously used `( ... )` subprocess for each init script
to prevent the `exit` command from exiting `rcS/K`.
Instead, define the `EXIT=return` in `rcS/K` and use `${EXIT:-exit}`
in the scripts instead of the `exit` command.
`${EXIT:-exit}` will expand to `exit` if `$EXIT` is not set,
allowing these scripts to be called directly as well.
This only applies to system scripts. We still use subshells
in `S99localscripts.sh` to avoid breaking any user scripts.
Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
Author
|
Confirmed that this boots on rg350m and gets all the way to "Spawning getty..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used
( ... )subprocess for each init script to prevent theexitcommand from exitingrcS/K.Instead, define the
EXIT=returninrcS/Kand use${EXIT:-exit}in the scripts instead of theexitcommand.${EXIT:-exit}will expand toexitif$EXITis not set, allowing these scripts to be called directly as well.This only applies to system scripts. We still use subshells in
S99localscripts.shto avoid breaking any user scripts.NEEDS TESTING