Add Dev Container, demo app, page in docs #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Notice this doesn't change any code in actual library, and the demo code is excluded from the package Next step; add browser tests of the app that run in both dev container and CI |
radix0000
approved these changes
Oct 9, 2025
Contributor
radix0000
left a comment
radix0000
left a comment
There was a problem hiding this comment.
Looks good. A few nitpicks, but nothing that would stop merging (especially if planning to address at later stage):
- Might be worth having a non-blank README.md, even if just copying a bit of text from docs (but a couple of lines on what repo is for would be good)
- Dockerfile is using python3.9 whose security support ends in 3 weeks
- fjorddemo/app/process.py: class DetailsOnJSON(TaskWithState): docstring, but empty
- On that note as an example/demo app is it worth having a few more docstrings/comments where could be useful for someone new to code base?
Contributor
Author
|
Put in issue - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.