-
Notifications
You must be signed in to change notification settings - Fork 1
Initial commit #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ke script to deploy for windows
…ctionality, added frontend load/unload/reload at runtime
…config files, removed GCC 8 errors
| @@ -6,6 +6,28 @@ OpenDashboard provides an Open-Source framework for rapid prototyping of car da | |||
|
|
|||
| A dashboard project can be be splitted up into two main components, the **frontend** that contains the actual design and the **backend** that provides the data to be visualized. OpenDashboard provides a generic backend that can be hooked up to different frontends to provide them with dynamic vehicle data (velocity, accelerations, engine signals, gps positioning data, etc.). OpenDashboard can receive data via a network socket (GoogleProtobuf messages via UDP) and therefore is able to work with prerecorded data from file or live data from a simulation or a real vehicle bus. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a dashboard project can be split up"
| @@ -1,5 +1,6 @@ | |||
| // Copyright (C) 2020 twyleg | |||
| // Copyright (C) 2020 twyleg | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use a license file?
| for (int i=0; i<strs.size(); ++i) | ||
| { | ||
| const std::string str = boost::algorithm::trim_copy(strs[i]); | ||
| if (str == "81") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "81"?
|
|
||
| for (int i=0; i<strs.size(); ++i) | ||
| { | ||
| const std::string str = boost::algorithm::trim_copy(strs[i]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get a better variable name than str?
| case GPS_MSG: | ||
| { | ||
| gps = packet.GetNextMessage<Gps>(); | ||
| mVehicleDataModel.SetPositionLon(gps.lon()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not have one method SetPosition that takes in a LatLon object? Seems to be a lot cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atleast as a QoL method
|
|
||
| Useful tools: | ||
|
|
||
| sudo apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please for your safety use some code tags
|
|
||
| #define AddAttribute(datatype, name, funcName, initial_value) \ | ||
| private: \ | ||
| datatype name = initial_value; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this? Why not just type it out? Or is this standard practice for this sort of thing
|
|
||
| FrontendLoader { | ||
| id: frontendLoader | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
|
|
||
| focus: false | ||
|
|
||
| property real lat: controlDataDynamicModel.lat// * (180.0 / 3.141591653) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the comment behind it?
| namespace { | ||
|
|
||
| const std::string OPEN_DASHBOARD_XSD = R"(<?xml version="1.0"?> | ||
| <xs:schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highly suggest having this in a file
First working version. Tested on Arch Linux with Qt 5.15.0 and Raspbian (RPi 3B) with Qt 5.15.1.