Skip to content

Fix bug that ignores additional stop criteria in Dud #448 #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikpelgrim wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug that ignores additional stop criteria in Dud #448 #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa566af
Fix bug that ignores additional stop criteria in Dud #448
erikpelgrim Jan 15, 2026
e15a92a
Do not execute extra stop criteria on inner iteration + improve loop
erikpelgrim Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions algorithms/java/src/org/openda/algorithms/BaseDudCoreOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,26 +433,20 @@ boolean isThereMoreToDo(double costs[], double relErrorLinCost, IVector predTry,
&& diff > relTol * Math.abs(costs[0])
&& relErrorLinCost>relTolLinCost;

// do not stop on a backtracking iteration
if (innerIter > 0 && imain < maxit) return true;

if (stopCriteria.isEmpty()) return moreToDo;
// additional stop criteria:
if (stopCriteria.size()>0) {
IVector residual = obs.clone();
residual.axpy(-1.0,predTry);
boolean isStop;
for (int i=0; i<stopCriteria.size(); i++){
IStopCriterion object = stopCriteria.get(i);
double threshold = stopCriteriaThreshold.get(i);
if (obsDescr!=null) {
isStop = object.checkForStop(pars[0],residual,obsDescr,costs[0],threshold);
} else {
isStop = object.checkForStop(pars[0],residual,costs[0],threshold);
}
Results.putMessage(object.toString());
this.moreToDo = this.moreToDo & !isStop;
}
IVector residual = obs.clone();
residual.axpy(-1.0, predTry);
for (int i = 0; i < stopCriteria.size(); i++) {
IStopCriterion stopCriterion = stopCriteria.get(i);
double threshold = stopCriteriaThreshold.get(i);
boolean isStop = obsDescr != null ? stopCriterion.checkForStop(pars[0], residual, obsDescr, costs[0], threshold) : stopCriterion.checkForStop(pars[0], residual, costs[0], threshold);
Results.putMessage(stopCriterion.toString());
moreToDo &= !isStop;
}

// do not stop on a backtracking iteration
if (innerIter>0 && (imain < maxit)) moreToDo = true;

return moreToDo;
}
Expand Down
Loading