Fix CI, update test dependencies, and remove the compile command#120
Merged
pavel-kirienko merged 19 commits intomainfrom May 12, 2025
Merged
Fix CI, update test dependencies, and remove the compile command#120pavel-kirienko merged 19 commits intomainfrom
pavel-kirienko merged 19 commits intomainfrom
Conversation
…lation screencasts as they are now obsolete
Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
This fixes the failing unit test `tests/cmd/execute_command.py`. The issue arose due to this implemented in `public_regulated_data_types`: OpenCyphal/public_regulated_data_types@ec27883 --------- Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the compile-related command and the associated "compiled_dsdl" parameters from numerous test functions, updates test dependencies and environment configurations, and revises CI workflow settings.
- Removed unused compile command parameters from tests
- Updated dependency versions (e.g. pycyphal from ~1.8 to ~1.20) and adjusted environment variables
- Revised CI configurations in setup.cfg, noxfile.py, and GitHub workflows
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cmd/register_list.py | Removed unused "compiled_dsdl" parameter and cleaned up env variables |
| tests/cmd/register_batch.py | Similar removal of "compiled_dsdl" and YAKUT_PATH cleanup |
| tests/cmd/register_access.py | Removed "compiled_dsdl" parameter with corresponding env modifications |
| tests/cmd/pubsub_sync.py & pubsub.py | Adjusted wait times and removed YAKUT_PATH references |
| tests/cmd/publish/* | Removed "compiled_dsdl" parameter and cleaned up YAKUT_PATH usage |
| tests/cmd/orchestrate/doc_examples.py | Removed "--path" arguments as part of removing compile dependencies |
| tests/cmd/monitor.py | Removed "compiled_dsdl" and added type: ignore for heartbeat assignments |
| tests/cmd/main.py | Updated command filtering logic for better command discovery |
| tests/cmd/file_server.py, execute_command.py, | Consistent removal of compile parameters and env updates |
| tests/cmd/call.py & accommodate.py | Removed "compiled_dsdl", streamlined environment configurations |
| setup.cfg, noxfile.py | Updated dependency versions and CI settings to support new configurations |
| README.md, CONTRIBUTING.md, others | Minor documentation and submodule updates |
| .github/workflows/test-and-release.yml | Updated workflow job names, steps and artifact retention policies |
Comments suppressed due to low confidence (2)
tests/cmd/main.py:16
- [nitpick] Ensure that filtering out commands starting with '@' does not inadvertently exclude any valid command implementations; verify that this change aligns with the overall command naming conventions.
if not cmd.startswith("_") and not cmd.startswith("@") and cmd not in ("pycyphal", "sys"):
noxfile.py:90
- [nitpick] Confirm that using os.environ instead of session.env to obtain the PATH variable is intentional and does not conflict with other session-specific environment settings.
"PATH": os.pathsep.join([os.environ["PATH"], str(DEPS_DIR)]),
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Closes #95