Implement FileClient2 progress callbacks#354
Merged
pavel-kirienko merged 4 commits intomasterfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements progress callback support for FileClient2 file operations and updates the associated type annotations.
- Introduces progress callbacks in file read and write operations.
- Updates type hints using the new union and list syntax.
- Adjusts test cases and bumps the version and changelog.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/application/file.py | Adds tests to validate progress callback functionality. |
| pycyphal/application/file.py | Implements progress callbacks and updates type annotations. |
| pycyphal/_version.py | Bumps version from 1.22.1 to 1.23.0. |
| CHANGELOG.rst | Updates changelog to document progress callback support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #353