Skip to content

Use ${LLVM_COV} variable instead of hardcoded llvm-cov#386

Merged
thirtytwobits merged 2 commits intollvm-source-coveragefrom
copilot/sub-pr-385
Dec 19, 2025
Merged

Use ${LLVM_COV} variable instead of hardcoded llvm-cov#386
thirtytwobits merged 2 commits intollvm-source-coveragefrom
copilot/sub-pr-385

Conversation

Copy link

Copilot AI commented Dec 19, 2025

Addresses feedback from #385 to use the CMake variable found by Findverification-coverage.cmake instead of hardcoding the tool name.

Changes

  • Pass LLVM_COV to generated coverage script via set(LLVM_COV "${LLVM_COV}")
  • Replace hardcoded llvm-cov with \${LLVM_COV} in all execute_process() commands (4 occurrences)

This matches the existing pattern for LLVM_PROFDATA and ensures the build uses the tool path discovered by CMake's find_program() rather than assuming it's in PATH.

# Before
execute_process(
    COMMAND llvm-cov show -format=html ...
)

# After  
execute_process(
    COMMAND \${LLVM_COV} show -format=html ...
)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: thirtytwobits <19180861+thirtytwobits@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on switching to LLVM source-based coverage Use ${LLVM_COV} variable instead of hardcoded llvm-cov Dec 19, 2025
Copilot AI requested a review from thirtytwobits December 19, 2025 04:51
@thirtytwobits thirtytwobits marked this pull request as ready for review December 19, 2025 17:04
@thirtytwobits thirtytwobits merged commit 8e980a8 into llvm-source-coverage Dec 19, 2025
1 check passed
@thirtytwobits thirtytwobits deleted the copilot/sub-pr-385 branch December 19, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants