Merged
Conversation
thirtytwobits
force-pushed
the
issue/351
branch
6 times, most recently
from
ba47775 to
e1909f7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Issue/351 by enhancing language standard support, including adding support for "c17" and "c23" and generating _Static_assert conditionally. Key changes include:
- Adding a new test (test_option_override) to verify command‑line option overrides.
- Updating language configuration and option override methods in nunavut/lang and nunavut/_generators.
- Enhancing CLI parsers and updating workflow matrices to include the new C standards.
Reviewed Changes
Copilot reviewed 10 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/gentest_nnvg/test_nnvg.py | Added test_option_override to verify --option argument processing. |
| test/gentest_lang/test_lang.py | Removed the redundant test_lang_cpp_use_vector test case. |
| src/nunavut/lang/_language.py | Updated _validate_language_options with inline tests in the docstring. |
| src/nunavut/lang/init.py | Changed language configuration type and added add_target_language_option_override. |
| src/nunavut/cli/parsers.py | Introduced MAX_LOG_ENTRY_LENGTH and a sanitization function for log messages. |
| src/nunavut/cli/init.py | Improved the keyvalue argument parser and refined extension handling. |
| src/nunavut/_version.py | Bumped version from 3.0.0.dev1 to 3.0.0.dev2. |
| src/nunavut/_generators.py | Added support for the --option argument; updated additional configuration handling. |
| .github/workflows/test.yml | Expanded the language matrix to include c-17 and c-23. |
Files not reviewed (10)
- README.rst: Language not supported
- src/nunavut/lang/c/support/serialization.j2: Language not supported
- src/nunavut/lang/c/templates/base.j2: Language not supported
- src/nunavut/lang/c/templates/definitions.j2: Language not supported
- src/nunavut/lang/c/templates/deserialization.j2: Language not supported
- src/nunavut/lang/c/templates/serialization.j2: Language not supported
- src/nunavut/lang/cpp/support/serialization.j2: Language not supported
- src/nunavut/lang/properties.json: Language not supported
- verification/CMakeLists.txt: Language not supported
- verification/CMakePresetsVendorTemplate.json: Language not supported
thirtytwobits
force-pushed
the
issue/351
branch
from
40fff02 to
e1909f7
Compare
Also adds --option argument and cpp_safe_c property to C header templates.
thirtytwobits
force-pushed
the
issue/351
branch
from
e1909f7 to
7fa3821
Compare
pavel-kirienko
approved these changes
Apr 29, 2025
Member
pavel-kirienko
left a comment
pavel-kirienko
left a comment
There was a problem hiding this comment.
I don't get the header replacement part but overall no strong objections.
Per comments and recent ISO guidance.
|
pavel-kirienko
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating _Static_assert unless c23 is specified.