fix: clean CI warnings and stabilize tests#78
Open
Sun-sunshine06 wants to merge 1 commit intoOpenCoworkAI:mainfrom
Open
fix: clean CI warnings and stabilize tests#78Sun-sunshine06 wants to merge 1 commit intoOpenCoworkAI:mainfrom
Sun-sunshine06 wants to merge 1 commit intoOpenCoworkAI:mainfrom
Conversation
hqhq1025
approved these changes
Mar 27, 2026
Collaborator
hqhq1025
left a comment
There was a problem hiding this comment.
✅ LGTM — Approve
Lint fixes are correct and don't change behavior. Symlink detection logic (supportsDirectorySymlinks() probe) is sound.
Minor observations (non-blocking)
plugin-runtime-service.test.tstimeout bump to 15s — the underlying mock-based test shouldn't need this. Worth investigating the root cause separately.ChatView.tsxResizeObserver useEffect has duplicateeslint-disable-next-linesuppressionMessageCard.tsxuseMemooncontentBlocksbusts every render during streaming (rawContent changes each time), providing no real optimization benefit- Logger
getLogContentpolling approach is slightly less reliable than the previous streamfinishevent. Acceptable for now but noted.
Collaborator
|
This PR has merge conflicts with the current |
Collaborator
|
Hi @Sun-sunshine06, thanks for the comprehensive CI cleanup work! I've cherry-picked the most valuable parts of this PR into main (commit 5206ba1): Adopted:
Not adopted (with reasons):
Your authorship is preserved via |
hqhq1025
pushed a commit
that referenced
this pull request
Mar 29, 2026
Cherry-pick valuable changes from Sun-sunshine06's PR #78: - Use .values() iterator in lima-bridge/wsl-bridge to eliminate unused _id - Add Windows symlink capability detection in dangling-symlink tests - Replace hardcoded paths with path.join and as-any with MountedPath type - Use vi.doUnmock instead of vi.unmock in store-encryption tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- clean the remaining lint warnings in main, renderer, and sandbox modules\n- make credential, path resolver, logger, and plugin runtime tests less brittle across platforms and slower CI runs\n- skip directory symlink-specific assertions when the local Windows environment cannot create symlinks\n\n## Verification\n- npm run lint\n- npm run typecheck\n- npm run test:coverage