Skip to content

Update for plugin API 2.0#22

Closed
matterhorn103 wants to merge 2 commits intoOpenChemistry:masterfrom
matterhorn103:plugin-api-2.0
Closed

Update for plugin API 2.0#22
matterhorn103 wants to merge 2 commits intoOpenChemistry:masterfrom
matterhorn103:plugin-api-2.0

Conversation

@matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Matthew Milner <matterhorn103@proton.me>
@matterhorn103
Copy link
Contributor Author

@ghutchis This is ready to go now :)

@ghutchis
Copy link
Member

Thanks, I just need to think a bit about whether to merge or keep it on a separate branch for a while during testing.

I'm leaning towards separate branch like openchemistry:dev2.0 or something?

@matterhorn103
Copy link
Contributor Author

That's a good question.

The way the plugin index and installer currently work, the plugin gets downloaded from this link in plugins.json:

zipball_url: "https://api.github.com/repos/OpenChemistry/avogenerators/zipball/1.98.0"

right?

So merging won't upset anything and I don't see a huge disadvantage to it.

Since we can assume there will be further changes to make after testing, I guess it comes down to whether you want to develop on master or not.

I'm fine with either option, just let me know if I need to change the PR or open a new one if you decide you want a dev branch.

@ghutchis
Copy link
Member

The main holdup is thinking about how it affects the continual builds or anyone compiling from source.

I'm probably likely to say "hey, I'm merging these pieces because it's becoming hard to keep it separate" and then it's fine to merge to HEAD

@avo-bot
Copy link

avo-bot commented Feb 20, 2026

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/interest-in-syntax-highlighting-for-orca/7316/4

Signed-off-by: Matthew Milner <matterhorn103@proton.me>
@ghutchis
Copy link
Member

Okay, I fixed some minor things in #23 - I can't seem to edit this PR. So I'm closing and merging that one.

@ghutchis ghutchis closed this Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants