Nonlinear fitting (work in progress) #151
Open
+1,301
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distance vector sign was updated in previous commits by setting: distanceVector(1:numberOfCoordinates)=interpolatedPoint%values(:,NO_PART_DERIV)-dataPointLocation and by multiplying gradient and Hessian values by -1 compared with the original implementation. However, with the updated code, the gradient values are the same as what the old code produced, however the Hessian isn't. Fix was to revert to the original implementation for the gradient and Hessian and setting the distance vector as: distanceVector(1:numberOfCoordinates)=dataPointLocation-interpolatedPoint%values(:,NO_PART_DERIV) This has been done for all cases of the projection (line, face, element).
This reverts commit 3c7f4ac.
…TTING_SUBTYPE Based this on those used for Finite Elasticity.
…iteElementCalculate (linear) Fitting_FiniteElementCalculate was originally used for EQUATIONS_SET_DATA_POINT_FITTING_SUBTYPE
Setting FiniteElementJacobianEvaluate to not implemented and instead will be calculated with FD
…eElementResidualEvaluate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #148