-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add support for displaying power status #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@synackd Would you mine reviewing this one, I seem to have lost my powers to add a reviewer ... |
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Can you provide testing instructions? My PCS environment is wonky, but I'd like to test if I can.
|
There's been a pretty big refactoring since this has been open. Commands have been organized into their own packages within a directory structure. @cjh1 Would you be able to rebase this and move this to the PCS package? |
Sure |
b3e07b2 to
f5b098a
Compare
|
@synackd This is fixed up |
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely looks good, I was able to build and run the help successfully. There were just a few small documentation-related changes requested.
912c80a to
c471841
Compare
Signed-off-by: Chris Harris <cjh@lbl.gov>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed the requested changes to avoid any further trouble. This should be good to merge, so I'm approving. Do you want to squash any commits?
Thanks, so you wanted a single space? No need to squash. |
I just wanted two spaces in front of the example commands (to align with the comments) and then have the man page reference dedented all of the way to align with the command description. Tested and now it renders as expected. :) |
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
Add support for showing/listing the power status of components
Type of Change
For more info, see Contributing Guidelines.