Skip to content

Conversation

@cjh1
Copy link
Member

@cjh1 cjh1 commented Oct 9, 2025

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Add support for showing/listing the power status of components

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@cjh1
Copy link
Member Author

cjh1 commented Oct 9, 2025

@synackd Would you mine reviewing this one, I seem to have lost my powers to add a reviewer ...

@synackd synackd self-requested a review October 9, 2025 22:23
Copy link
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you provide testing instructions? My PCS environment is wonky, but I'd like to test if I can.

@synackd
Copy link
Collaborator

synackd commented Feb 4, 2026

There's been a pretty big refactoring since this has been open. Commands have been organized into their own packages within a directory structure. @cjh1 Would you be able to rebase this and move this to the PCS package?

@cjh1
Copy link
Member Author

cjh1 commented Feb 5, 2026

There's been a pretty big refactoring since this has been open. Commands have been organized into their own packages within a directory structure. @cjh1 Would you be able to rebase this and move this to the PCS package?

Sure

@cjh1 cjh1 force-pushed the pcs-status branch 2 times, most recently from b3e07b2 to f5b098a Compare February 5, 2026 15:44
@cjh1
Copy link
Member Author

cjh1 commented Feb 5, 2026

@synackd This is fixed up

Copy link
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good, I was able to build and run the help successfully. There were just a few small documentation-related changes requested.

@cjh1 cjh1 force-pushed the pcs-status branch 2 times, most recently from 912c80a to c471841 Compare February 5, 2026 21:28
Signed-off-by: Chris Harris <cjh@lbl.gov>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Copy link
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and pushed the requested changes to avoid any further trouble. This should be good to merge, so I'm approving. Do you want to squash any commits?

@cjh1
Copy link
Member Author

cjh1 commented Feb 5, 2026

I went ahead and pushed the requested changes to avoid any further trouble. This should be good to merge, so I'm approving. Do you want to squash any commits?

Thanks, so you wanted a single space? No need to squash.

@synackd
Copy link
Collaborator

synackd commented Feb 5, 2026

I went ahead and pushed the requested changes to avoid any further trouble. This should be good to merge, so I'm approving. Do you want to squash any commits?

Thanks, so you wanted a single space? No need to squash.

I just wanted two spaces in front of the example commands (to align with the comments) and then have the man page reference dedented all of the way to align with the command description.

Tested and now it renders as expected. :)

% ./ochami pcs status show --help
Show power status of target component.

See ochami-pcs(1) for more details.

Usage:
  ochami pcs status show <xname> [flags]

Examples:
  # show power status of component
  ochami pcs status show x3000c0s15b0
...
% ./ochami pcs status list --help
List active PCS transitions.

See ochami-pcs(1) for more details.

Usage:
  ochami pcs status list [flags]

Examples:
  # List status
  ochami pcs status list

@synackd synackd merged commit ee95e45 into OpenCHAMI:main Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants