Fix various issues, improve log messages, update documentation, and add regression tests#126
Open
davidallendj wants to merge 15 commits intomainfrom
Open
Fix various issues, improve log messages, update documentation, and add regression tests#126davidallendj wants to merge 15 commits intomainfrom
davidallendj wants to merge 15 commits intomainfrom
Conversation
Collaborator
Author
|
Still need to add the regression tests before merging. |
db8035d to
1c99115
Compare
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com> Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
6230841 to
4d188cf
Compare
cjh1
reviewed
Feb 6, 2026
| IPMI SerialConsoleConfig `json:"impi,omitempty"` | ||
| Telnet SerialConsoleConfig `json:"telnet,omitempty"` | ||
| SSH SerialConsoleConfig `json:"ssh,omitempty"` | ||
| } |
Member
There was a problem hiding this comment.
Ther is also support for websocket console in RF, the remote console service currently doesn't support it, but we might want to add it here for completeness, not sure if gofish supports it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
This PR adds documentation that about using
--insecurewithscanafter changing the default value tofalse. It also adds more log messages to find these related issues and fixes an issue related to closing the secrets file too early, and adds regression tests.Additionally, this adds
SerialConsoleandCommandShellto the output of the crawler.Type of Change
For more info, see Contributing Guidelines.