Skip to content

Fix various issues, improve log messages, update documentation, and add regression tests#126

Open
davidallendj wants to merge 15 commits intomainfrom
allend/fix-issues
Open

Fix various issues, improve log messages, update documentation, and add regression tests#126
davidallendj wants to merge 15 commits intomainfrom
allend/fix-issues

Conversation

@davidallendj
Copy link
Collaborator

@davidallendj davidallendj commented Oct 8, 2025

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This PR adds documentation that about using --insecure with scan after changing the default value to false. It also adds more log messages to find these related issues and fixes an issue related to closing the secrets file too early, and adds regression tests.

Additionally, this adds SerialConsole and CommandShell to the output of the crawler.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@davidallendj davidallendj marked this pull request as draft October 8, 2025 18:48
@davidallendj
Copy link
Collaborator Author

Still need to add the regression tests before merging.

@davidallendj davidallendj marked this pull request as ready for review February 5, 2026 17:01
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
Copy link
Member

@cjh1 cjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

IPMI SerialConsoleConfig `json:"impi,omitempty"`
Telnet SerialConsoleConfig `json:"telnet,omitempty"`
SSH SerialConsoleConfig `json:"ssh,omitempty"`
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ther is also support for websocket console in RF, the remote console service currently doesn't support it, but we might want to add it here for completeness, not sure if gofish supports it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants