Updating ccg2xml to use Python 3 #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally removed some outdated imports and comments. One "arg == None" was changed to "arg is None".
- Using 2to3 and some manual labor - Especially comments can be overlooked - Updating lex.py and yacc.py - Tested the changes with arabic.ccg - The editor buttons are broken with this version
It still works fine inside a debian-docker container using XQuartz on the host system. Windows will be tested soon.
The content of Features and Testbed is presented properly again. Before, only the last items were shown, as the indentation level was one too few.
Contributor
Author
|
Some screenshots: MacOS: Debian via Docker/XQuartz on MacOS host: Windows: |
Open
dmhowcroft
reviewed
Dec 30, 2018
Contributor
|
Looks good to me, @mwhite14850 |
Contributor
Author
|
I found another two instances of the list() around items() calls and updated those (and the one reviewed above) accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to update the ccg_editor.py and all other ccg2xml files to Python 3. Note that this change breaks backwards compatibility as the scripts are no longer compatible with Python 2.
Tkinter now uses ttk instead of the plain tkinter. Before, in Python 3, the GUI was not working properly on MacOS. Now it works with MacOS and inside a (debian) Docker container, tunneling the X server to the host OS. I will test Windows support soon and report.
Note that this PR depends (loosely) on #18 and includes those commits as well. Thus, this PR closes #18 and also closes #16.
Even though this updates the ccg_editor.py (and thus visccg) heavily, it does not implement solutions for the missing panel "Rules", nor any more functionality for the Testbed panel, even if those are needed.
I didn't get line numbers in the main window to work, neither with the original Python 2 code nor with the updated Python 3 code. However, the code is still in there and maybe it can be fixed somehow, but that is outside the scope of this PR.