Fix secret unpacking

[ryan-pratt]

If you only pass three values (like the example in our docs), Ruby unpacks nil but Python throws ValueError: not enough values to unpack (expected 4, got 3)

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.18%. Comparing base (6ba6927) to head (3a6cf8a).

Files with missing lines	Patch %	Lines
openc3/lib/openc3/utilities/secrets.rb	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
- Coverage   79.19%   79.18%   -0.02%     
==========================================
  Files         670      670              
  Lines       54253    54259       +6     
  Branches      734      734              
==========================================
- Hits        42967    42964       -3     
- Misses      11206    11215       +9     
  Partials       80       80              

Flag	Coverage Δ
python	81.00% <ø> (-0.02%)	⬇️
ruby-api	83.61% <ø> (-0.05%)	⬇️
ruby-backend	82.20% <25.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcosgriff]

Shouldn't we also check that they array has at least 3 elements as well? If secrets is [1,2] it will raise ValueError: not enough values to unpack (expected at least 3, got 2)

[ryan-pratt]

That would be an invalid config. Shouldn't we error in that case?

[jmthomas]

How do these secrets get set? As long as it is validated when it is set then there can only be 3 or 4 items. I'm just not sure where or if this validation is occuring.

[ryan-pratt]

They come from the microservice config. I don't see checks earlier in the microservice initialization logic than here, so I'm adding a check here