Skip to content

Conversation

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Jan 15, 2026

Prior to this fix if a screen in Command Sender has an error the entire Command Sender screen darkens.

  • Go to INST SETPARAMS and edit the screen to add a bad item. Verify before and after behavior.

This also fixes the transient screen error issue.

  • Got to Telemetry Viewer and open a few screens. Then zdocker pause cosmos-openc3-cosmos-cmd-tlm-api-1. Observe screen error (dimming). Then docker unpause cosmos-openc3-cosmos-cmd-tlm-api-1 and observe recovery.

closes #2720

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.31%. Comparing base (8112540) to head (3575c08).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
- Coverage   79.22%   78.31%   -0.92%     
==========================================
  Files         670      473     -197     
  Lines       54178    34451   -19727     
  Branches      734      734              
==========================================
- Hits        42924    26979   -15945     
+ Misses      11174     7392    -3782     
  Partials       80       80              
Flag Coverage Δ
python 96.03% <ø> (+15.04%) ⬆️
ruby-api 84.19% <ø> (+0.04%) ⬆️
ruby-backend 82.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas merged commit 5654959 into main Jan 16, 2026
43 of 47 checks passed
@jmthomas jmthomas deleted the fix_overlay branch January 16, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual issue with screens not clearing telemetry request error on their own

3 participants