Adding support for Postmark Tags#34
Open
jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom
jxmallett:tags
Open
Adding support for Postmark Tags#34jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom jxmallett:tags
jxmallett wants to merge 1 commit intoOpenBuildings:masterfrom
jxmallett:tags
Conversation
Contributor
|
@jxmallett Sorry for the late response! Do you think you could look into the tests and rebase on top of latest master? If not, that's fine - just let me know and I'll try to update it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postmark has support for tagging emails to aid with statistics. I think we can use the Swift ID property to do the same thing.
Swift automatically generates a 'unique' ID like
[hash]@[domain]but you can set your own with$message->setId('blah');and this bit of code will tag the Postmark message with that ID.I think this would technically be a BC break because it changes the default behaviour - Emails used to be sent with no tag, but they'll now default to sending with Swift's auto-generated tag.