Real life handling of the ExpressCheckout#11
Closed
boryn wants to merge 2 commits intoOpenBuildings:masterfrom
Closed
Real life handling of the ExpressCheckout#11boryn wants to merge 2 commits intoOpenBuildings:masterfrom
boryn wants to merge 2 commits intoOpenBuildings:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
All transactions happen in an overlayer modal box, users will not need to leave your site during the whole process unlike other methods, where users will be redirected to PayPal official site to make payment.
I've always used ExpressCheckout with a redirect to paypal.com. I've previously have set up a popup and an iframe versions of a PayPal checkout. But I think the ExpressCheckout docs explain the flow with a redirect.
Could you point to the relevant PayPal documentation? Thanks!
Contributor
|
@boryn Thank you for your work! Especially the documentation fixes! Could you address the inline comments? |
Contributor
|
Closing this one in favour of #12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ExpressCheckout mode there are no shipment costs and order items must be specified (even when doing
do_express_checkout_payment()). I made some changes to the order,$paramsbuilding and gave more infromation in the example.PS. I also think the address 'www.paypal.com/incontext?token=' at which user is redirected after calling
$express_checkout->set_express_checkout()should also be set as a constant in Payment class.