Fix Qt 6.8 warnings #1074
Open
Fix Qt 6.8 warnings #1074
+72
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vekhir
force-pushed
the
fix-qt6.8-warnings
branch
from
0232d4f to
5624946
Compare
Qt 6.8 introduces a new system to manage permissions for websites Building with Qt 6.7 and earlier is unaffected due to extensive preprocessor directives.
The old version of setContent returns bool and takes in pointers to allow access to the error information. This was replaced in Qt 6.5 with a ParseResult struct which allows boolean checking and direct access to the information without additional pointers. The old version had separate overloads to specify whether to use namespace processing or not. This, among other options, can now be specified via ParseOptions which were introduced in Qt 6.5 too.
QDateTime::setTimeSpec is deprecated in Qt 6.9 per documentation, but already emits a warning in Qt 6.8. Anyway, use setTimeZone.
Vekhir
force-pushed
the
fix-qt6.8-warnings
branch
from
5624946 to
0e7a184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Qt 6.8 release, several deprecations and changes are made. In preparation for that, this PR resolves the emitted warnings when building with Qt 6.8 Beta 3.
Except for the new permissions system introduced in 6.8, the changes modernise the current code and adopt current best practices.
The permissions system changes how Qt handles permission requests from websites. Most importantly, it saves the permissions itself, so we don't have to.
Tested with
permission.site. All new code is enclosed in preprocessor directives, as is the old permission management, to remove it with Qt 6.8+.Builds fine with Qt 6.7.2, Qt 6.8 Beta 3, Qt 5.15.14.