fix for #468 and partial solution to #413 #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added some e2e tests to make sure things are above board but there is a bit of potential uncertainty. Frustratingly, this is a part of the GQL architechture that leads to a growing number of utility types that developers need to keep track of. Because I do not have a good insight into how many services still depend on the old user profile resolutions I have left them untouched - though it could be argued they need to be deprecated. As far as resolving user nodes on Media, this is simply a danger we are going to accept. We'd like to PREVENT resolving greedily in places where it's not necessary but really there's nothing we can do to prevent fronent devs from doing silly things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some e2e tests to make sure things are above board but there is a bit of potential uncertainty. Frustratingly, this is a part of the GQL architechture that leads to a growing number of utility types that developers need to keep track of.
Because I do not have a good insight into how many services still depend on the old user profile resolutions I have left them untouched - though it could be argued they need to be deprecated.
As far as resolving user nodes on Media, this is simply a danger we are going to accept. We'd like to PREVENT resolving greedily in places where it's not necessary but really there's nothing we can do to prevent fronent devs from doing silly things