Avoid mixing wheels between publish jobs #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope artifacts by run id/attempt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #215 where the non-aarch64 publish job was also uploading the aarch64 wheel from the same workflow run.
The reusable publish workflow was downloading all artifacts matching dist-*, so every publish job could see wheels from other build jobs.
I made the wheel and sdist artifact names in publish.yml include the build target and updated the publish jobs to download only their own artifact instead of dist-*.
I run the publish workflow on the fix/artifact-scope branch and it no longer mixes artifacts between jobs. I’ll add the GitHub Actions run link here . https://github.com/aditya-pandey-dev/github-actions-workflows/actions/runs/20006487200